Messages in this thread | | | Date | Sun, 27 Feb 2011 00:16:58 +0100 | Subject | Re: [PATCH] Add ``cloneconfig'' target | From | Miguel Ojeda <> |
| |
On Sat, Feb 26, 2011 at 11:57 PM, Arnaud Lacombe <lacombar@gmail.com> wrote: > Hi, > > On Sat, Feb 26, 2011 at 5:47 PM, Miguel Ojeda > <miguel.ojeda.sandonis@gmail.com> wrote: >> On Sat, Feb 26, 2011 at 8:47 PM, Arnaud Lacombe <lacombar@gmail.com> wrote: >>> Why ? Thing should be kept simple. kconfig's job is not to know about >>> the trillion file format which exist in the world, even more if the >>> implementation is made by building a command[0], executing it in a >>> separate process and reading the output. This is the shell's job. What >>> may be useful in the contrary would be to eventually teach kconfig to >>> read from <stdin>. >> >> /proc/config.gz is provided by the kernel and its format is defined by >> kconfig itself which is, as well, part of the kernel (it is not one >> random format from a pool of a trillion), so it will be nice if >> kconfig learns how to read its own configuration from there. >> > your point being ? kconfig is not only used by the Linux kernel, and > you cannot expect the feature to only be used in the cozy Linux kernel > environment.
My point was that supporting reading from a .gz file is not anywhere near "knowing about the trillion file format which exist in the world" (and I was not talking about a "hack", see below).
> >> kconfig only knows about config files (one format). The fact that it's >> gzipped its irrelevant, any reasonable machine capable of building the >> kernel has gzip installed. >> > again, the average user has no interaction with kconfig directly, > (s)he uses the top level Makefile target at best. The original patch > of Jeff is way better than any hack to read a gzip file from kconfig. > KISS and please don't reinvert the wheel.
I agree with that. I understood that you were against adding support for reading /proc/config.gz whether patching the Makefile or teaching kconfig how to do that.
Miguel
> > - Arnaud > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |