lkml.org 
[lkml]   [2011]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 6/6] Staging: hv: Cleanup hyperv_driver variable names
On Fri, Feb 25, 2011 at 06:07:58PM -0800, K. Y. Srinivasan wrote:
> The title says it all.
>

For this patch the rename_rev.pl command is:

rename_rev.pl -nc -e 's/(drv|driver)_ctx/drv/g'

> --- a/drivers/staging/hv/vmbus_drv.c
> +++ b/drivers/staging/hv/vmbus_drv.c
> @@ -46,7 +46,7 @@ struct vmbus_hyperv_driver {
> /* FIXME, this is a bug */
> /* The driver field is not used in here. Instead, the bus field is */
> /* used to represent the driver */
^^
This comment out of date now that we're using container_of().

> - struct hyperv_driver drv_ctx;
> + struct hyperv_driver dummy;
^^^^^
Delete.

> @@ -849,18 +849,18 @@ static int vmbus_uevent(struct device *device, struct kobj_uevent_env *env)
> static int vmbus_match(struct device *device, struct device_driver *driver)
> {
> int match = 0;
> - struct hyperv_driver *driver_ctx = driver_to_hyperv_driver(driver);
> + struct hyperv_driver *drv = driver_to_hyperv_driver(driver);
> struct hyperv_device *device_obj = device_to_hyperv_device(device);
>
> /* We found our driver ? */
> - if (memcmp(&device_obj->class_id, &driver_ctx->class_id,
> + if (memcmp(&device_obj->class_id, &drv->class_id,
> sizeof(struct hv_guid)) == 0) {
> /*
> - * !! NOTE: The driver_ctx is not a vmbus_drv_ctx. We typecast
> + * !! NOTE: The drv is not a vmbus_drv_ctx. We typecast
^^^^
Out of date.

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-02-26 04:43    [W:0.075 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site