lkml.org 
[lkml]   [2011]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [cpuops cmpxchg double V3 3/5] Generic support for this_cpu_cmpxchg_double
On Fri, 25 Feb 2011, Steven Rostedt wrote:

> > + VM_BUG_ON((unsigned long)(&pcp1) % (2 * sizeof(pcp1))); \
> > + VM_BUG_ON((unsigned long)(&pcp2) != (unsigned long)(&pcp1) + sizeof(pcp1));\
> > + VM_BUG_ON(sizeof(pcp1) != sizeof(pcp2)); \
>
> Since this is a macro, and it looks like all these are constants (sizeof
> and addresses), couldn't you just do a BUILD_BUG_ON() instead?

The addresses are not constant.


\
 
 \ /
  Last update: 2011-02-25 21:47    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site