Messages in this thread | | | Date | Fri, 25 Feb 2011 21:07:22 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH V2] sdhci: always use max timeout for xfers |
| |
On Fri, Feb 25, 2011 at 10:49:25AM -0800, Philip Rakity wrote: > v2 > > use define for max timeout. remove subroutine call and just > set the register directly
The generic description goes above the "---" line, the incremental history of the patch usually below.
> > v1 > > The card/host controller may sometimes return a value that is > too low and cause the h/w to timeout a transfer that would have > worked. Using the maximum value avoids this. > > Signed-off-by: Philip Rakity <prakity@marvell.com>
What is there seems ok, but it is not enough yet. The quirks can also go from the users.
After that, it gets even more complicated; after this patch 'host->timeout_clk' becomes obsolete which should probably cleaned up in a later patch together with host->ops->get_timeout_clk. Hmmmm, that needs careful auditing.
Regards,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |