lkml.org 
[lkml]   [2011]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] regulator, mc13xxx: Remove pointless test for unsigned less than zero
From
Date
On Wed, 2011-02-23 at 23:45 +0100, Jesper Juhl wrote:
> The variable 'val' is a 'unsigned int', so it can never be less than zero.
> This fact makes the "val < 0" part of the test done in BUG_ON() in
> mc13xxx_regulator_get_voltage() rather pointles since it can never have
> any effect.
> This patch removes the pointless test.


Ok for me, but the next time give also the revision of the kernel
your patch is based on (Linus one, Liam one ..) that is the
linus-2.6.38-rc6

Acked-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>

>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> mc13xxx-regulator-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
> index f53d31b..2bb5de1 100644
> --- a/drivers/regulator/mc13xxx-regulator-core.c
> +++ b/drivers/regulator/mc13xxx-regulator-core.c
> @@ -174,7 +174,7 @@ static int mc13xxx_regulator_get_voltage(struct regulator_dev *rdev)
>
> dev_dbg(rdev_get_dev(rdev), "%s id: %d val: %d\n", __func__, id, val);
>
> - BUG_ON(val < 0 || val > mc13xxx_regulators[id].desc.n_voltages);
> + BUG_ON(val > mc13xxx_regulators[id].desc.n_voltages);
>
> return mc13xxx_regulators[id].voltages[val];
> }
>
>

--
Alberto!

Be Persistent!
- Greg Kroah-Hartman (FOSDEM 2010)



\
 
 \ /
  Last update: 2011-02-24 10:15    [W:0.066 / U:5.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site