lkml.org 
[lkml]   [2011]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH ] Staging: hv: Hyper-V driver cleanup
On Thu, Feb 24, 2011 at 03:20:58PM -0800, K. Y. Srinivasan wrote:
> This patch cleans up (a lot of the) naming issues that
> various reviewers have noted. It also gets rid of
> some unnecessary layering in the code.

Whenever you have a patch description that says "It also..." you know
you need to break this up into smaller, logical pieces.

As it is, I can not take this patch.

Please break it up into logical patches, each doing only one thing, so
we can properly review it.

> At the lowest
> level, we have one abstraction for representing
> a hyperv device (struct hyperv_device) and one
> abstraction for representing a hyperv driver
> (struct hyperv_driver). This collapses an unnecessary
> layering that existed in the code for historical reasons.
> While the patch is large, it was generated by a very
> mechanical process (global search and replace). The code
> compiles cleanly and I have tested this code on a 2.6.38
> kernel.

There is no 2.6.38 kernel yet, so I find this very hard to believe :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-02-25 00:49    [W:0.039 / U:1.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site