Messages in this thread | | | Date | Wed, 23 Feb 2011 15:43:49 +0530 | From | Balbir Singh <> | Subject | Re: [CFS Bandwidth Control v4 5/7] sched: add exports tracking cfs bandwidth control statistics |
| |
* Paul Turner <pjt@google.com> [2011-02-23 00:03:42]:
> On Mon, Feb 21, 2011 at 8:40 PM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote: > > * Bharata B Rao <bharata@linux.vnet.ibm.com> [2011-02-22 09:43:33]: > > > >> > > >> > Should we consider integrating this in cpuacct, it would be difficult > >> > if we spill over stats between controllers. > >> > >> Given that cpuacct controller can be mounted independently, I am not sure > >> if we should integrate these stats. These stats come from cpu controller. > > > > The accounting controller was created to account. I'd still prefer > > cpuacct, so that I can find everything in one place. NOTE: cpuacct was > > created so that we do accounting with control - just account. I think > > splitting stats creates a usability mess - no? > > > > One problem with rolling it into cpuacct is that some of the > statistics have a 1:1 association with the hierarchy being throttled. > For example, the number of periods in which throttling occurred or the > count of elapsed periods. > > If it were rolled into cpuacct the only meaningful export would be the > total throttled time -- perhaps this is sufficient? >
Good point, lets keep it as is. nr_throttled and nr_periods is also important (although it can be derived).
-- Three Cheers, Balbir
| |