| Date | Wed, 23 Feb 2011 10:52:35 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH RFC tip/core/rcu 11/11] rcu: move TREE_RCU from softirq to kthread |
| |
On Wed, Feb 23, 2011 at 09:02:01AM -0500, Mathieu Desnoyers wrote: > * Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote: > [...] > > + for (cpu = rnp->grplo; cpu <= rnp->grphi; cpu++, mask <<= 1) > > + if (mask & 01) > > Wow, octal notation! ;)
/me pauses to thank the octal-notation PDP-12, CDC 3300, CDC Cyber 73, and PDP-11 systems for funding my college education. The two CDC systems had ones-complement in the bargain. ;-)
> Maybe we could consider 0x1 here.
Good catch, fixed. The hex says "bitmask" to me.
Thanx, Paul
|