Messages in this thread | | | Date | Wed, 23 Feb 2011 18:37:25 +0100 | From | "Hans J. Koch" <> | Subject | Re: [PATCH v3 1/2] PRUSS UIO driver support |
| |
On Wed, Feb 23, 2011 at 07:22:40PM +0530, Pratheesh Gangadhar wrote: > This patch implements PRUSS (Programmable Real-time Unit Sub System) > UIO driver which exports SOC resources associated with PRUSS like > I/O, memories and IRQs to user space. PRUSS is dual 32-bit RISC > processors which is efficient in performing embedded tasks that > require manipulation of packed memory mapped data structures and > efficient in handling system events that have tight real time > constraints. This driver is currently supported on Texas Instruments > DA850, AM18xx and OMAPL1-38 devices. > For example, PRUSS runs firmware for real-time critical industrial > communication data link layer and communicates with application stack > running in user space via shared memory and IRQs. > > Signed-off-by: Pratheesh Gangadhar <pratheesh@ti.com> > --- > drivers/uio/Kconfig | 17 ++++ > drivers/uio/Makefile | 1 + > drivers/uio/uio_pruss.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 241 insertions(+), 0 deletions(-) > create mode 100644 drivers/uio/uio_pruss.c >
[...]
> + > +static int __devinit pruss_probe(struct platform_device *dev) > +{ > + int ret = -ENODEV, count = 0; > + struct resource *regs_prussio, *regs_l3ram, *regs_ddr; > + struct uio_info *p; > + > + info = kzalloc(sizeof(struct uio_info) * MAX_PRUSS_EVTOUT_INSTANCE, > + GFP_KERNEL); > + if (!info) > + return -ENOMEM; > + > + /* Power on PRU in case its not done as part of boot-loader */ > + pruss_clk = clk_get(&dev->dev, "pruss"); > + if (IS_ERR(pruss_clk)) { > + dev_err(&dev->dev, "Failed to get clock\n"); > + ret = PTR_ERR(pruss_clk); > + return ret;
You leak memory here. What about freeing "info"?
> + } else { > + clk_enable(pruss_clk); > + }
Thanks, Hans
| |