lkml.org 
[lkml]   [2011]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [CFS Bandwidth Control v4 5/7] sched: add exports tracking cfs bandwidth control statistics
From
Date
On Tue, 2011-02-15 at 19:18 -0800, Paul Turner wrote:
> + raw_spin_lock(&cfs_b->lock);
> + cfs_b->throttled_time += (rq->clock - cfs_rq->throttled_timestamp);
> + raw_spin_unlock(&cfs_b->lock);

That seems to put the cost of things on the wrong side. Read is rare,
update is frequent, and you made the frequent thing the most expensive
one.




\
 
 \ /
  Last update: 2011-02-23 14:35    [from the cache]
©2003-2011 Jasper Spaans