lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[12/70] vt: fix issue when fbcon wants to takeover a second time.
    2.6.37-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Dave Airlie <airlied@redhat.com>

    commit c55c63c6539499379ab4a7e8a5c0f857351fb946 upstream.

    With framebuffer handover and multiple GPUs, we get into a
    position where the fbcon unbinds the vesafb framebuffer for GPU 1,
    but we still have a radeon framebuffer bound from GPU 0, so
    we don't unregister the console driver. Then when we tried to bind
    the new radeon framebuffer for GPU1 we never get to the bind
    call as we fail due to the console being registered already.

    This changes the return value to -EBUSY when the driver is
    already registered and continues to bind for -EBUSY.

    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/tty/vt/vt.c | 9 +++++++--
    1 file changed, 7 insertions(+), 2 deletions(-)

    --- a/drivers/tty/vt/vt.c
    +++ b/drivers/tty/vt/vt.c
    @@ -3524,7 +3524,7 @@ int register_con_driver(const struct con

    /* already registered */
    if (con_driver->con == csw)
    - retval = -EINVAL;
    + retval = -EBUSY;
    }

    if (retval)
    @@ -3635,7 +3635,12 @@ int take_over_console(const struct consw
    int err;

    err = register_con_driver(csw, first, last);
    -
    + /* if we get an busy error we still want to bind the console driver
    + * and return success, as we may have unbound the console driver
    +  * but not unregistered it.
    + */
    + if (err == -EBUSY)
    + err = 0;
    if (!err)
    bind_con_driver(csw, first, last, deflt);


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-02-22 23:37    [W:0.025 / U:30.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site