lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[44/70] ALSA: caiaq - Fix possible string-buffer overflow
    2.6.37-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit eaae55dac6b64c0616046436b294e69fc5311581 upstream.

    Use strlcpy() to assure not to overflow the string array sizes by
    too long USB device name string.

    Reported-by: Rafa <rafa@mwrinfosecurity.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    sound/usb/caiaq/audio.c | 2 +-
    sound/usb/caiaq/midi.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    --- a/sound/usb/caiaq/audio.c
    +++ b/sound/usb/caiaq/audio.c
    @@ -785,7 +785,7 @@ int snd_usb_caiaq_audio_init(struct snd_
    }

    dev->pcm->private_data = dev;
    - strcpy(dev->pcm->name, dev->product_name);
    + strlcpy(dev->pcm->name, dev->product_name, sizeof(dev->pcm->name));

    memset(dev->sub_playback, 0, sizeof(dev->sub_playback));
    memset(dev->sub_capture, 0, sizeof(dev->sub_capture));
    --- a/sound/usb/caiaq/midi.c
    +++ b/sound/usb/caiaq/midi.c
    @@ -136,7 +136,7 @@ int snd_usb_caiaq_midi_init(struct snd_u
    if (ret < 0)
    return ret;

    - strcpy(rmidi->name, device->product_name);
    + strlcpy(rmidi->name, device->product_name, sizeof(rmidi->name));

    rmidi->info_flags = SNDRV_RAWMIDI_INFO_DUPLEX;
    rmidi->private_data = device;



    \
     
     \ /
      Last update: 2011-02-22 23:31    [W:3.393 / U:1.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site