lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[40/70] workqueue: make sure MAYDAY_INITIAL_TIMEOUT is at least 2 jiffies long
    2.6.37-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Tejun Heo <tj@kernel.org>

    commit 3233cdbd9fa347a6d6897a94cc6ed0302ae83c4f upstream.

    MAYDAY_INITIAL_TIMEOUT is defined as HZ / 100 and depending on
    configuration may end up 0 or 1. Even when it's 1, depending on when
    the mayday timer is added in the current jiffy interval, it may expire
    way before a jiffy has passed.

    Make sure MAYDAY_INITIAL_TIMEOUT is at least two to guarantee that at
    least a full jiffy has passed before calling rescuers.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Reported-by: Ray Jui <rjui@broadcom.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    kernel/workqueue.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/kernel/workqueue.c
    +++ b/kernel/workqueue.c
    @@ -79,7 +79,9 @@ enum {
    MAX_IDLE_WORKERS_RATIO = 4, /* 1/4 of busy can be idle */
    IDLE_WORKER_TIMEOUT = 300 * HZ, /* keep idle ones for 5 mins */

    - MAYDAY_INITIAL_TIMEOUT = HZ / 100, /* call for help after 10ms */
    + MAYDAY_INITIAL_TIMEOUT = HZ / 100 >= 2 ? HZ / 100 : 2,
    + /* call for help after 10ms
    + (min two ticks) */
    MAYDAY_INTERVAL = HZ / 10, /* and then every 100ms */
    CREATE_COOLDOWN = HZ, /* time to breath after fail */
    TRUSTEE_COOLDOWN = HZ / 10, /* for trustee draining */



    \
     
     \ /
      Last update: 2011-02-22 23:27    [W:0.021 / U:29.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site