lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subjectlinux-next: build failure after merge of the final tree (wireless tree related)
    Hi all,

    After merging the final tree, today's linux-next build (powerpc
    allyesconfig) failed like this:

    drivers/net/wireless/rtlwifi/rtl8192cu/sw.c: In function 'rtl92cu_init_sw_vars':
    drivers/net/wireless/rtlwifi/rtl8192cu/sw.c:60: error: implicit declaration of function 'vmalloc'
    drivers/net/wireless/rtlwifi/rtl8192cu/sw.c:60: warning: assignment makes pointer from integer without a cast
    drivers/net/wireless/rtlwifi/rtl8192cu/sw.c: In function 'rtl92cu_deinit_sw_vars':
    drivers/net/wireless/rtlwifi/rtl8192cu/sw.c:74: error: implicit declaration of function 'vfree'

    Caused by commit 442888c706e90634c4cc3441751b43115a7d8506 ("rtlwifi:
    rtl8192cu: Add routines dm, fw, led and sw"). Missing an include of
    linux/vmalloc.h. See Rule 1 in Documentation/SubmitChecklist.

    I added the following patch:

    From: Stephen Rothwell <sfr@canb.auug.org.au>
    Date: Tue, 22 Feb 2011 17:29:04 +1100
    Subject: [PATCH] rtlwifi: include vmalloc.h for needed routines

    Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
    ---
    drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
    index 4e937e0..c69861e 100644
    --- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
    +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
    @@ -27,6 +27,8 @@
    *
    *****************************************************************************/

    +#include <linux/vmalloc.h>
    +
    #include "../wifi.h"
    #include "../core.h"
    #include "../usb.h"
    --
    1.7.4.1
    but then got:

    drivers/net/wireless/rtlwifi/rtl8192cu/built-in.o: In function `rtl92c_phy_sw_chnl':
    (.opd+0xf30): multiple definition of `rtl92c_phy_sw_chnl'
    drivers/net/wireless/rtlwifi/rtl8192ce/built-in.o:(.opd+0xb70): first defined here
    drivers/net/wireless/rtlwifi/rtl8192cu/built-in.o: In function `rtl92c_fill_h2c_cmd':
    (.opd+0x288): multiple definition of `rtl92c_fill_h2c_cmd'
    drivers/net/wireless/rtlwifi/rtl8192ce/built-in.o:(.opd+0x288): first defined here

    and lots more.

    So I have used the wireless tree from next-20110221 for today.
    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/


    \
     
     \ /
      Last update: 2011-02-22 08:17    [W:0.025 / U:29.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site