Messages in this thread Patch in this message | | | Date | Tue, 22 Feb 2011 23:29:15 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/2] debugfs: only allow root access to debugging interfaces |
| |
On Tue, Feb 22, 2011 at 11:33:14AM -0800, Greg KH wrote: > Again, let's fix the real problems here, world-writable debugfs files.
We could just ban them?
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index e7a7a2f..03ae095 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -223,6 +223,9 @@ struct dentry *debugfs_create_file(const char *name, mode_t mode, pr_debug("debugfs: creating file '%s'\n",name); + /* don't allow world writable files */ + mode &= ~S_IWOTH; + error = simple_pin_fs(&debug_fs_type, &debugfs_mount, &debugfs_mount_count); if (error)
| |