[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] fix pgd_lock deadlock
    On Tue, Feb 22, 2011 at 09:08:54AM -0800, Jeremy Fitzhardinge wrote:
    > On 02/22/2011 06:34 AM, Andrea Arcangeli wrote:
    > > On Tue, Feb 22, 2011 at 02:22:53PM +0000, Jan Beulich wrote:
    > >> If everyone's okay with putting a couple of "if (xen_pv_domain())"
    > >> into mm/fault.c - sure. I would have thought that this wouldn't be
    > >> liked, hence the suggestion to make this depend on seeing the
    > >> backlink be non-NULL.
    > > I prefer the if (xen_pv_domain) so it also gets optimized away
    > > at build time when CONFIG_XEN=n. I think it's also more self
    > > explanatory to read.
    > Eh, very not keen about that. I'd only consider it as a last resort.
    > In practice CONFIG_XEN is always enabled in distros, so the conditional
    > would always be done at runtime.

    That's ok, it's still better than setting a page filed IMHO. As the
    page flag would be set conditional to xen_pv_domain() anyway. I
    wouldn't like to make things more complicated than they already are,
    this will make it more explicit why that spinlock is needed too.
    Unless we foresee other hypervisors using a generic functionality we
    don't need one.

     \ /
      Last update: 2011-02-22 18:17    [W:0.020 / U:7.088 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site