Messages in this thread |  | | | Date | Mon, 21 Feb 2011 20:33:16 +0100 | | From | "Hans J. Koch" <> | | Subject | Re: [PATCH 1/2] PRUSS UIO driver support |
| |
On Mon, Feb 21, 2011 at 09:27:47AM +0530, TK, Pratheesh Gangadhar wrote: > Hi Hans, > > > -----Original Message----- > > From: Hans J. Koch [mailto:hjk@hansjkoch.de] > > Sent: Sunday, February 20, 2011 12:04 AM > > To: TK, Pratheesh Gangadhar > > Cc: Thomas Gleixner; Arnd Bergmann; linux-arm-kernel@lists.infradead.org; > > davinci-linux-open-source@linux.davincidsp.com; gregkh@suse.de; > > Chatterjee, Amit; Hans J. Koch; LKML > > Subject: Re: [PATCH 1/2] PRUSS UIO driver support > > > > On Sat, Feb 19, 2011 at 09:10:23PM +0530, TK, Pratheesh Gangadhar wrote: > > > > > > For my understanding - if the interrupt is not shared and not level > > triggered - > > > is this okay to have empty handler? > > > > Greg already said he won't accept that. And I'm quite sure these > > interrupts > > are level triggered, since that is the default on arch/omap. > > > > E.g. in arch/arm/mach-omap1/irq.c, a loop sets all irqs to level triggered > > handling: set_irq_handler(j, handle_level_irq); (line 234) > > You should be looking at arch/arm/mach-davinci/irq.c
Hmpf. I alway get lost in the directory structure of TI SoCs... At least I learned that OMAP3 is in the omap2 directory :)
> and all interrupts except IRQ_TINT1_TINT34 is set to edge trigger mode (line 160).
Is that really needed? Level triggered interrupts should certainly be preferred if possible.
Thanks, Hans
|  |