lkml.org 
[lkml]   [2011]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [tip:irq/core] genirq: Make nr_irqs runtime expandable
    On Mon, 21 Feb 2011, Lars-Peter Clausen wrote:
    > On 02/19/2011 08:07 PM, Yinghai Lu wrote:
    > > On 02/19/2011 04:15 AM, tip-bot for Thomas Gleixner wrote:
    > > - if (start >= nr_irqs) {
    > > + if (start + cnt > nr_irqs) {
    > > ret = irq_expand_nr_irqs(cnt);
    > Just a minor thing, but if there are still unused irqs available at the end of
    > the current range, you'll end up expanding the range more then you need to.
    > So either do
    > irq_expand_nr_irqs(nr_irqs - start + cnt);
    > or change irq_expand_nr_irqs to let it take the new total number of irqs.

    Fun, I already changed YH's patch in that way :)

    > Btw., with this patch in place does it make sense to initialize nr_irqs to
    > anything else then initcnt in early_irq_init?

    Probably not.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2011-02-21 20:21    [W:0.021 / U:60.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site