Messages in this thread | | | Date | Mon, 21 Feb 2011 18:21:03 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH v2 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h |
| |
On 02/21, Peter Zijlstra wrote: > > afaict its needed because struct signal_struct and struct sighand_struct > include a wait_queue_head_t. The inclusion seems to come through > completion.h, but afaict we don't actually need to include completion.h > because all we have is a pointer to a completion, which is perfectly > fine with an incomplete type. > > This all would suggest we move the signal bits into their own header > (include/linux/signal.h already exists and seems inviting).
Agreed, sched.h contatins a lot of garbage, including the signal bits.
As for signal_struct in particular I am not really sure, it is just misnamed. It is in fact "struct process" or "struct thread_group". But dequeue_signal/etc should go into signal.h.
The only problem, it is not clear how to test such a change.
Oleg.
| |