Messages in this thread | | | Date | Mon, 21 Feb 2011 16:08:11 +0200 | From | Felipe Balbi <> | Subject | Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h |
| |
Hi,
On Mon, Feb 21, 2011 at 04:05:14PM +0200, David Cohen wrote: > On Mon, Feb 21, 2011 at 3:57 PM, Felipe Balbi <balbi@ti.com> wrote: > > Hi, > > > > On Mon, Feb 21, 2011 at 03:51:25PM +0200, Alexey Dobriyan wrote: > >> > I rather have the split done and kill the circular dependency. > >> > >> It's not circular for starters. > > > > how come ? wait.h depends on sched and sched.h depends on wait.h > > The tricky thing is wait.h doesn't depend on sched.h, but the file > which uses wake_up*() macro defined on wait.h will depend on sched.h > (what is still bad). wait.h should provide all dependencies to use a
That's why I say wait.h depends on sched.h because it uses a macro defined in sched.h
-- balbi
| |