Messages in this thread Patch in this message | | | From | Minchan Kim <> | Subject | [PATCH v2 1/2] memcg: remove unnecessary BUG_ON | Date | Mon, 21 Feb 2011 00:17:17 +0900 |
| |
Now memcg in unmap_and_move checks BUG_ON of charge. But mem_cgroup_prepare_migration returns either 0 or -ENOMEM. If it returns -ENOMEM, it jumps out unlock without the check. If it returns 0, it can pass BUG_ON. So it's meaningless. Let's remove it.
Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Balbir Singh <balbir@linux.vnet.ibm.com> Acked-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Signed-off-by: Minchan Kim <minchan.kim@gmail.com> --- mm/migrate.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c index eb083a6..2abc9c9 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -683,7 +683,6 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private, rc = -ENOMEM; goto unlock; } - BUG_ON(charge); if (PageWriteback(page)) { if (!force || !sync) -- 1.7.1
| |