Messages in this thread | | | Date | Wed, 2 Feb 2011 15:32:21 -0800 | From | Frank Rowand <> | Subject | Re: [PATCH] softirq: Avoid stack switch from ksoftirqd |
| |
On 02/02/11 08:10, Thomas Gleixner wrote: > ksoftirqd() calls do_softirq() which switches stacks on several > architectures. That makes no sense at all. ksoftirqd's stack is > sufficient. > > Call __do_softirq() directly. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frank Rowand <frank.rowand@am.sony.com>
> --- > kernel/softirq.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > Index: linux-2.6-tip/kernel/softirq.c > =================================================================== > --- linux-2.6-tip.orig/kernel/softirq.c > +++ linux-2.6-tip/kernel/softirq.c > @@ -738,7 +738,10 @@ static int run_ksoftirqd(void * __bind_c > don't process */ > if (cpu_is_offline((long)__bind_cpu)) > goto wait_to_die; > - do_softirq(); > + local_irq_disable(); > + if (local_softirq_pending()) > + __do_softirq(); > + local_irq_enable(); > preempt_enable_no_resched(); > cond_resched(); > preempt_disable(); > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
| |