Messages in this thread | | | From | Paul Menage <> | Date | Fri, 18 Feb 2011 18:28:50 -0800 | Subject | Re: [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK_ALLOC() |
| |
On Thu, Feb 17, 2011 at 6:47 PM, Li Zefan <lizf@cn.fujitsu.com> wrote: > > I think a defect of this is people might call it twice in one function > but don't know it returns the same variable?
Hopefully they'd read the comments...
But it's not a big issue either way - having the WARN_ON() statements in front of each use works OK too, given that there are only a few of them.
Paul
| |