lkml.org 
[lkml]   [2011]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] PRUSS UIO driver support
    On Fri, 18 Feb 2011, Arnd Bergmann wrote:
    > On Friday 18 February 2011, Pratheesh Gangadhar wrote:
    > > Signed-off-by: Pratheesh Gangadhar <pratheesh@ti.com>
    > > +static irqreturn_t pruss_handler(int irq, struct uio_info *dev_info)
    > > +{
    > > + return IRQ_HANDLED;
    > > +}
    >
    > An empty interrupt handler is rather pointless. I guess you really
    > notify user space when the interrupt handler gets called, as this
    > is the main point of a UIO driver as far as I understand it.

    The UIO core code does this for you when the driver handler returns
    IRQ_HANDLED, but the empty handler raises a different questions:

    Is the interrupt edge triggerd or how do you avoid an irq storm here?
    Usually UIO drivers are requested to mask the interrupt in the device
    itself.

    Thanks,

    tglx



    \
     
     \ /
      Last update: 2011-02-18 17:17    [W:0.022 / U:1.184 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site