lkml.org 
[lkml]   [2011]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] Driver core: convert platform_{get,set}_drvdata to static inline functions
    Hello,

    On Wed, Feb 16, 2011 at 11:23:27PM +0100, Marc Kleine-Budde wrote:
    > This patch converts the macros for platform_{get,set}_drvdata to
    > static inline functions to add typechecking.
    >
    > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    > ---
    > Changes since v1:
    > - remove ugly macro magic, use static inline functions instead
    >
    > include/linux/platform_device.h | 11 +++++++++--
    > 1 files changed, 9 insertions(+), 2 deletions(-)
    >
    > diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
    > index 2e700ec..d96db98 100644
    > --- a/include/linux/platform_device.h
    > +++ b/include/linux/platform_device.h
    > @@ -130,8 +130,15 @@ extern void platform_driver_unregister(struct platform_driver *);
    > extern int platform_driver_probe(struct platform_driver *driver,
    > int (*probe)(struct platform_device *));
    >
    > -#define platform_get_drvdata(_dev) dev_get_drvdata(&(_dev)->dev)
    > -#define platform_set_drvdata(_dev,data) dev_set_drvdata(&(_dev)->dev, (data))
    > +static inline void *platform_get_drvdata(const struct platform_device *pdev)
    > +{
    > + return dev_get_drvdata(&pdev->dev);
    > +}
    > +
    > +static inline void platform_set_drvdata(struct platform_device *pdev, void *data)
    > +{
    > + dev_set_drvdata(&pdev->dev, data);
    > +}
    Another improvement would be to make dev_set_drvdata and
    platform_set_drvdata return an int (as dev_set_drvdata can fail) (and
    then maybe mark it __must_check).

    Other than that,

    Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    Best regards
    Uwe

    --
    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-02-17 09:49    [W:0.026 / U:62.652 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site