Messages in this thread | | | Date | Thu, 17 Feb 2011 14:46:43 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK_ALLOC() |
| |
On Thu, 17 Feb 2011 09:50:09 +0800 Li Zefan <lizf@cn.fujitsu.com> wrote:
> +/* > + * In functions that can't propogate errno to users, to avoid declaring a > + * nodemask_t variable, and avoid using NODEMASK_ALLOC that can return > + * -ENOMEM, we use this global cpuset_mems. > + * > + * It should be used with cgroup_lock held.
I'll do s/should/must/ - that would be a nasty bug.
I'd be more comfortable about the maintainability of this optimisation if we had
WARN_ON(!cgroup_is_locked());
at each site.
> + */ > +static nodemask_t cpuset_mems;
| |