lkml.org 
[lkml]   [2011]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist()
    It's not necessary to copy cpuset->mems_allowed to a buffer
    allocated by NODEMASK_ALLOC(). Just pass it to nodelist_scnprintf().

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    ---
    kernel/cpuset.c | 10 +---------
    1 files changed, 1 insertions(+), 9 deletions(-)

    diff --git a/kernel/cpuset.c b/kernel/cpuset.c
    index 10f1835..f13ff2e 100644
    --- a/kernel/cpuset.c
    +++ b/kernel/cpuset.c
    @@ -1620,20 +1620,12 @@ static int cpuset_sprintf_cpulist(char *page, struct cpuset *cs)

    static int cpuset_sprintf_memlist(char *page, struct cpuset *cs)
    {
    - NODEMASK_ALLOC(nodemask_t, mask, GFP_KERNEL);
    int retval;

    - if (mask == NULL)
    - return -ENOMEM;
    -
    mutex_lock(&callback_mutex);
    - *mask = cs->mems_allowed;
    + retval = nodelist_scnprintf(page, PAGE_SIZE, cs->mems_allowed);
    mutex_unlock(&callback_mutex);

    - retval = nodelist_scnprintf(page, PAGE_SIZE, *mask);
    -
    - NODEMASK_FREE(mask);
    -
    return retval;
    }

    --
    1.7.3.1

    \
     
     \ /
      Last update: 2011-02-17 02:51    [W:0.019 / U:61.372 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site