Messages in this thread | | | Subject | Re: Linux 2.6.38-rc5 | From | Eric Dumazet <> | Date | Wed, 16 Feb 2011 17:22:39 +0100 |
| |
Le mercredi 16 février 2011 à 07:46 -0800, Linus Torvalds a écrit : > On Wed, Feb 16, 2011 at 3:14 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > > > > Using this kernel on my dev machine (2x4x2 cpus), I hit BUG_ON() in > > fs/namei.c:1461 on my kernel build (make -j16) > > Uhhuh. We replaced one BUG_ON() with another. > > And I think it's a really silly problem too: when Al moved the > > /* We drop rcu-walk here */ > if (nameidata_dentry_drop_rcu_maybe(nd, path->dentry)) > return -ECHILD; > > test into do_follow_link(), he _should_ have moved the BUG_ON() in > there too, methinks. He didn't, and as a result the BUG_ON() is now > before the "drop_rcu_maybe". > > This patch should fix it. Al? Comments? >
Yes it does, lets see Al patch ;)
> (Of course, we could just remove the BUG_ON() entirely, but > considering that this is still fragile new code I'd rather leave it > in) > > Linus
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |