lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[069/115] pata_mpc52xx: inherit from ata_bmdma_port_ops
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Tejun Heo <tj@kernel.org>

    commit 77c5fd19075d299fe820bb59bb21b0b113676e20 upstream.

    pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which
    triggers BUG_ON() when a DMA command is issued. Fix it.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Reported-by: Roman Fietze <roman.fietze@telemotive.de>
    Cc: Sergei Shtylyov <sshtylyov@mvista.com>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/ata/pata_mpc52xx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/ata/pata_mpc52xx.c
    +++ b/drivers/ata/pata_mpc52xx.c
    @@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx
    };

    static struct ata_port_operations mpc52xx_ata_port_ops = {
    - .inherits = &ata_sff_port_ops,
    + .inherits = &ata_bmdma_port_ops,
    .sff_dev_select = mpc52xx_ata_dev_select,
    .set_piomode = mpc52xx_ata_set_piomode,
    .set_dmamode = mpc52xx_ata_set_dmamode,



    \
     
     \ /
      Last update: 2011-02-16 02:57    [W:4.118 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site