[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[055/115] p54: fix sequence no. accounting off-by-one error
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.


    From: Christian Lamparter <>

    commit 3b5c5827d1f80ad8ae844a8b1183f59ddb90fe25 upstream.

    P54_HDR_FLAG_DATA_OUT_SEQNR is meant to tell the
    firmware that "the frame's sequence number has
    already been set by the application."

    Whereas IEEE80211_TX_CTL_ASSIGN_SEQ is set for
    frames which lack a valid sequence number and
    either the driver or firmware has to assign one.

    Yup, it's the exact opposite!

    Signed-off-by: Christian Lamparter <>
    Signed-off-by: John W. Linville <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/net/wireless/p54/txrx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/wireless/p54/txrx.c
    +++ b/drivers/net/wireless/p54/txrx.c
    @@ -617,7 +617,7 @@ static void p54_tx_80211_header(struct p
    *burst_possible = false;

    - if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ)
    + if (!(info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ))
    *flags |= P54_HDR_FLAG_DATA_OUT_SEQNR;

    if (info->flags & IEEE80211_TX_CTL_PSPOLL_RESPONSE)

     \ /
      Last update: 2011-02-16 02:55    [W:0.020 / U:4.640 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site