lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: cx23885-input.c does in fact use a workqueue....
Hello,

On Mon, Feb 14, 2011 at 07:54:36PM -0500, Andy Walls wrote:
> > 1. Just flush the work items explicitly using flush_work_sync().
>
> That will do for now.
>
> > 2. Create a dedicated workqueue to serve as flushing domain.
>
> I have gotten reports of the IR Rx FIFO overflows for the CX23885 IR Rx
> unit (the I2C connected one). I eventually should either set the Rx
> FIFO service interrupt watermark down from 4 measurments to 1
> measurment, or use a kthread_worker with some higher priority to respond
> to the IR Rx FIFO service interrupt.

Hmmm... please consider playing with WQ_HIGHPRI before going forward
with dedicated thread.

> > The first would look like the following. Does this look correct?
>
> Yes, your patch below looks sane to me.
>
> Reviewed-by: Andy Walls <awalls@md.metrocast.net>

Thanks. Will send patch with proper description soon.

--
tejun


\
 
 \ /
  Last update: 2011-02-15 10:15    [W:0.063 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site