lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hidinput: kernel oops in out_cleanup in function hidinput_connect
On Tue, 15 Feb 2011, Dmitry Torokhov wrote:

> > Goto out_cleanup infers a kernel oops: hidinput_disconnect calls
> > input_unregister_driver to all members of hid->inputs.
> > However, hidinput already has been added to hid->inputs even
> > though input_register_device was not called.
> >
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
>
> Yep, well spotted.
>
> Reviewed-by: Dmitry Torokhov <dtor@mail.ru>

Indeed, thanks a lot for spotting this Benjamin. Apparently this codepath
is not excercised too heavily (which is good :) ).

Applied.

--
Jiri Kosina
SUSE Labs, Novell Inc.


\
 
 \ /
  Last update: 2011-02-15 23:51    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site