lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 6/6] hpsa: fix bad comparison
    From
    Date
    From: Dan Carpenter <error27@gmail.com>

    '!' has higher precedence than '&'. CFGTBL_ChangeReq is 0x1 so the
    original code is equivelent to if (!doorbell_value) {...

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Acked-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
    ---
    drivers/scsi/hpsa.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
    index eb6938f..c30591f 100644
    --- a/drivers/scsi/hpsa.c
    +++ b/drivers/scsi/hpsa.c
    @@ -3614,7 +3614,7 @@ static void __devinit hpsa_wait_for_mode_change_ack(struct ctlr_info *h)
    spin_lock_irqsave(&h->lock, flags);
    doorbell_value = readl(h->vaddr + SA5_DOORBELL);
    spin_unlock_irqrestore(&h->lock, flags);
    - if (!doorbell_value & CFGTBL_ChangeReq)
    + if (!(doorbell_value & CFGTBL_ChangeReq))
    break;
    /* delay and try again */
    usleep_range(10000, 20000);


    \
     
     \ /
      Last update: 2011-02-15 22:37    [W:2.942 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site