lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] x86: ifdef enable_IR_x2apic() out
Am 14.02.2011 12:03, schrieb Ingo Molnar:
>
>
> * Henrik Kretzschmar <henne@nachtwindheim.de> wrote:
>
>> +#ifdef CONFIG_X86_64
>> extern void enable_IR_x2apic(void);
>> +#endif
>
> Cannot we use the CONFIG_X86_X2APIC Kconfig switch here, instead of CONFIG_X86_64?
>
> enable_IR_x2apic() is not a 64-bit CPU feature.
>
> Thanks,
>
> Ingo
>
>

Thats what I had liked also.

At the time you moved the apic code from x86/kernel it was exactly that way.
But after that, in commit 937582382c71b75b29fbb92615629494e1a05ac0, it was explicitely moved out of
CONFIG_X86_X2APIC, which made that function also compile on 32bit machines, even if its not used there.

Also commit ce69a784504222c3ab6f1b3c357d09ec5772127a enabled the x2apic without interrupt remapping,
which means that CONFIG_X86_X2APIC depends on CONFIG_INTR_REMAP has been bypassed and so Kconfig is
broken/not representing what happens to the code.

So since I dont have an x2apic and therefore cannot test changes,
I decided for CONFIG_X86_64 without touching code which seems to work.

I wish I could offer something better here.

Greets,
Henrik Kretzschmar






\
 
 \ /
  Last update: 2011-02-15 14:51    [W:0.078 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site