Messages in this thread | | | Date | Tue, 15 Feb 2011 07:04:00 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller |
| |
On Tue, 15 Feb 2011, Kirill A. Shutemov wrote: > On Mon, Feb 14, 2011 at 06:01:06PM +0100, Thomas Gleixner wrote: > > > I think silent change here is wrong. cpuset returns -EBUSY in similar > > > case. > > > > And how is cpuset relevant for this ? Not at all. This is about > > timer_slack and we better have a well defined scheme for all of this > > and not some cobbled together thing with tons of exceptions and corner > > cases. Of course undocumented as far the code goes. > > I don't like silent cascade changes. Userspace can implement it if > needed. -EBUSY is appropriate.
And I don't like totally uncommented code which follows come cobbled together completely non obvious rules.
It's not about what you like. It's about getting useful functionality when we add a new infrastructure like this.
So could you please explain what the rules of updating are, so that a reviewer has a chance to understand the rationale of all this.
Thanks,
tglx
| |