lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/26] x86-64, NUMA: Unify {acpi|amd}_{numa_init|scan_nodes}() arguments and return values
On Sat, Feb 12, 2011 at 10:39:03AM -0800, Yinghai Lu wrote:
> > @@ -297,7 +297,10 @@ int __init acpi_numa_init(void)
> > acpi_table_parse(ACPI_SIG_SLIT, acpi_parse_slit);
> >
> > acpi_numa_arch_fixup();
> > - return ret;
> > +
> > + if (cnt <= 0)
> > + return cnt ?: -ENOENT;
> > + return 0;
> > }
> >
> > int acpi_get_pxm(acpi_handle h)
>
>
> it will break AMD system that does not have SRAT.
>
> your change will treat NO_SRAT as SRAT is there.

Can you please elaborate a bit? Yinghai, there's brevity and there's
being cryptic. I appreciate your reviews but don't want to spend time
trying to decipher what you mean. If it doesn't hurt your fingers too
much, please put a bit more effort into explaining.

Thank you.

--
tejun


\
 
 \ /
  Last update: 2011-02-14 12:31    [W:0.162 / U:65.724 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site