lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: char/ipmi: cleanup_one_si section mismatch
    Yeah, I should have noticed this.

    Acked-by: Corey Minyard <cminyard@mvista.com>

    On 02/14/2011 09:03 AM, Sergey Senozhatsky wrote:
    > Hello,
    >
    > commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
    > Author: Corey Minyard<minyard@acm.org>
    > Date: Thu Feb 10 16:08:38 2011 -0600
    >
    > char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver
    >
    >
    > Introduced section mismatch by calling __exit cleanup_ipmi_si
    > from __devinit init_ipmi_si. Should we remove __exit annotation then?
    >
    >
    > ---
    >
    > drivers/char/ipmi/ipmi_si_intf.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
    > index 7855f9f..94cd2ce 100644
    > --- a/drivers/char/ipmi/ipmi_si_intf.c
    > +++ b/drivers/char/ipmi/ipmi_si_intf.c
    > @@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
    > kfree(to_clean);
    > }
    >
    > -static void __exit cleanup_ipmi_si(void)
    > +static void cleanup_ipmi_si(void)
    > {
    > struct smi_info *e, *tmp_e;
    >
    >



    \
     
     \ /
      Last update: 2011-02-15 00:33    [W:2.812 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site