lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] drivers/char/hw_random/omap-rng.c: Convert release_resource to release_region/release_mem_region
    On Mon, Feb 14, 2011 at 04:42:24PM -0600, Matt Mackall wrote:
    > On Sun, 2011-02-13 at 13:12 +0100, Julia Lawall wrote:
    > > Request_region should be used with release_region, not release_resource.
    > >
    > > The local variable mem, storing the result of request_mem_region, is
    > > dropped and instead the pointer res is stored in the drvdata field of the
    > > platform device. This information is retrieved in omap_rng_remove to
    > > release the region. The drvdata field is not used elsewhere.
    > >
    > > The semantic match that finds this problem is as follows:
    > > (http://coccinelle.lip6.fr/)
    >
    > Looks ok to me, Herbert?

    Yes I will apply it today.

    Thanks,
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2011-02-14 23:49    [W:0.023 / U:0.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site