Messages in this thread | | | Date | Mon, 14 Feb 2011 11:03:35 -0800 | From | Yinghai Lu <> | Subject | Re: [PATCH UPDATED 03/26] x86, NUMA: Drop @start/last_pfn from initmem_init() initmem_init() |
| |
On 02/14/2011 06:58 AM, Tejun Heo wrote: > On Mon, Feb 14, 2011 at 03:20:11PM +0100, Ingo Molnar wrote: >> You forgot to add: >> >> Reported-by: Yinghai Lu <yinghai@kernel.org> >> >> The kernel development process is review and testing limited and we have a clear >> oversupply in development power. So we want to encourage review and testing feedback >> as much as possible, so adding all the Reported-by / Tested-by tags is absolutely >> vital to being able to do more development. > > git tree updated accordingly, but Reported-by? I use that to identify > the person who found out the root problem the commit is addressing. > Once review cycle is complete, Reviewed/Acked-by's will be added so > I'm not sure adding Reported-by serves any purpose.
could be something in change log for -v2
initmem_init() extensively accesses and modifies global data structures and the parameters aren't even followed depending on which path is being used. Drop @start/last_pfn and let it deal with @max_pfn directly. This is in preparation for further NUMA init cleanups.
-v2: x86-32 initmem_init() weren't updated breaking 32bit builds. Fixed. Found by Yinghai
| |