lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] gpiolib: Add ability to get GPIO pin direction
From
Date
> > We need four states for a gpio pin direction though. A pin can be
> >
> > - input
> > - output
>
> There are actually multiple output modes that a specific gpio
> controller could implement, but the gpio api only has a boolean
> understanding of output. I don't know if it is really worthwhile to
> try and encode all the possible configurations in this API.
>
> > - unknown (hardware lacks get functionality and it has not been set by
> > software yet)

I'm not sure how we could handle unknown directions in a better way. We
really should know the direction by this point for most (all?) GPIO
chips. I'd think the proper fix would be to make sure we can detect a
direction for all chips - either by reading hardware bits or by having
the platform code let us know (eg pdata->n_latch in pcf857x.c). If you
have a suggestion about how unknown pins should be used, I can look into
it and submit a follow up patch.

> > - alt_func (pin is in use for some other purpose)
>
> What is the use-case for alt_func? From the point of view of a GPIO
> driver, I don't think it cares if the pin has been dedicated to
> something else. It can twiddle all it wants, but if the pin is routed
> to something else then it won't have any external effects (pin mux is
> often a separate logic block from the gpio controller). Also with
> GPIOs, the engineers fiddling with them *really* needs to know what
> the gpios are routed to. It is highly unlikely to have any kind of
> automatic configuration of gpios; ie. if it isn't wired as a gpio,
> then don't go twiddling it.

Additionally, for this case I thought the low level GPIO driver should
implement a request() function to prevent a non-GPIO pin from being used
in the first place. Eg like chip_gpio_request() in cs5535-gpio.c, or
ichx_gpio_request() in patch 3 of this series.

> > (and being able to set them alt_func was proposed a while ago and I think
> > wants revisiting judging by the number of platforms which use gpio, and
> > in their own arch code are privately handling alt_func stuff)
>
> Fair enough; convince me on alt_func. What is the use case that I'm missing?

Peter



\
 
 \ /
  Last update: 2011-02-14 18:49    [W:0.131 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site