lkml.org 
[lkml]   [2011]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets
    From
    Date
    On Fri, 2011-02-11 at 12:51 -0800, Steve Muckle wrote:
    > On 02/11/11 12:42, Daniel Walker wrote:
    > >> static struct resource msm_iommu_jpegd_resources[] = {
    > >> {
    > >> - .start = MSM_IOMMU_JPEGD_PHYS,
    > >> - .end = MSM_IOMMU_JPEGD_PHYS + MSM_IOMMU_JPEGD_SIZE - 1,
    > >> + .start = 0x07300000,
    > >> + .end = 0x07300000 + SZ_1M - 1,
    > >
    > > Looks worse .. Just put the macros into a static header file for both.
    >
    > Why bother defining macros for these if they only appear here? I don't
    > think that adds any value or readability - these addresses are clearly
    > the physical area for the msm_iommu_jpegd. It just makes it more
    > annoying to have to look up the values in a separate file if you are
    > wondering what they are.

    So your saying if you look at the number 0x07300000 you instantly know
    that this JPEGD? What if I pick a random other kernel developer do you
    think they would instantly know that? I have no idea what 0x07300000 is.

    Also if it's in a header you could ifdef them with out touching the C
    file, which is just forward looking.

    Daniel


    --
    Sent by an consultant of the Qualcomm Innovation Center, Inc.
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
    Forum.




    \
     
     \ /
      Last update: 2011-02-11 22:01    [W:0.019 / U:38.580 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site