[lkml]   [2011]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V3 1/1] ST SPEAr: PCIE gadget suppport
On Fri, 11 Feb 2011 12:52:04 +0530 pratyush <> wrote:

> >>> This interface implies that there will only ever be one device in the
> >>> machine, yes? Seems a bit short-sighted?
> >>>
> >>
> >> This device supports only one BAR in EP mode.
> >
> > I don't understand that.
> >
> > What happens if someone builds a computer with three of these devices
> > in it?
> >
> I understood it. I will modify the code to work with multiple instances of
> pcie device.

I don't think you need to go that far, unless you see a significant
likelihood think that such a computer might be created one day. This
depends on how hard and risky such a change is, of course.

But the current driver's userspace interface should at least
anticipate the possibility, so you aren't trapped into a weird or
non-back-compatible interface in the future.

So for now you might choose to do something as simple as renaming
/config/pcie-gadget to /config/pcie-gadget0 and leave it at that.

 \ /
  Last update: 2011-02-11 08:33    [from the cache]
©2003-2011 Jasper Spaans