Messages in this thread | | | Subject | Re: [PATCH 5/5] have smaps show transparent huge pages | From | Dave Hansen <> | Date | Thu, 10 Feb 2011 10:20:32 -0800 |
| |
On Thu, 2011-02-10 at 19:09 +0100, Andrea Arcangeli wrote: > Maybe it'd be cleaner if we didn't need to cast the pmd to pte_t but I > guess this makes things simpler.
Yeah, I'm not a huge fan of doing that, either. But, I'm not sure what the alternatives are. We could basically copy smaps_pte_entry() to smaps_pmd_entry(), and then try to make pmd variants of all of the pte functions and macros we call in there.
I know there's a least a bit of precedent in the hugetlbfs code for doing things like this, but it's not a _great_ excuse. :)
-- Dave
| |