lkml.org 
[lkml]   [2011]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 05/20] pata_efar: always program master_data before slave_data
    From
    Hi,

    On Thu, Feb 10, 2011 at 3:23 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
    > Hello.
    >
    > On 08-02-2011 15:24, Bartlomiej Zolnierkiewicz wrote:
    > [...]
    >
    >> We may need to set SITRE before programming slave_data.
    >
    >> This makes pata_efar match the behavior of IDE's slc90e66 host driver
    >> and also of libata's ata_piix one.
    >
    >> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
    >
    > [...]
    >
    >> diff --git a/drivers/ata/pata_efar.c b/drivers/ata/pata_efar.c
    >> index 1e2ff7d..7f564d7 100644
    >> --- a/drivers/ata/pata_efar.c
    >> +++ b/drivers/ata/pata_efar.c
    >> @@ -74,10 +74,12 @@ static void efar_set_timings(struct ata_port *ap,
    >> struct ata_device *adev,
    >>                             u8 pio, bool use_mwdma)
    >>  {
    >>        struct pci_dev *dev     = to_pci_dev(ap->host->dev);
    >> +       unsigned int is_slave   = (adev->devno != 0);
    >
    >   What's the point of this variable? To save one pointer dereference? :-)

    Make code more similar to ata_piix.c and thus easier for comparisons
    through 'diff -ub'.

    In reality it doesn't matter now that much as pata_efar (same for
    pata_oldpiix) vanishes completely at the end of the patch series.. :-)

    Thanks,
    Bartlomiej
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-02-10 18:17    [W:0.040 / U:31.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site