| | From | Andi Kleen <> | | Subject | [PATCH] [113/139] fix freeing user_struct in user cache | | Date | Tue, 1 Feb 2011 16:45:12 -0800 (PST) |
| |
2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Hillf Danton <dhillf@gmail.com> commit 4ef9e11d6867f88951e30db910fa015300e31871 upstream.
When racing on adding into user cache, the new allocated from mm slab is freed without putting user namespace.
Since the user namespace is already operated by getting, putting has to be issued.
Signed-off-by: Hillf Danton <dhillf@gmail.com> Acked-by: Serge Hallyn <serge@hallyn.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Andi Kleen <ak@linux.intel.com>
--- kernel/user.c | 1 + 1 file changed, 1 insertion(+) Index: linux-2.6.35.y/kernel/user.c =================================================================== --- linux-2.6.35.y.orig/kernel/user.c +++ linux-2.6.35.y/kernel/user.c @@ -157,6 +157,7 @@ struct user_struct *alloc_uid(struct use spin_lock_irq(&uidhash_lock); up = uid_hash_find(uid, hashent); if (up) { + put_user_ns(ns); key_put(new->uid_keyring); key_put(new->session_keyring); kmem_cache_free(uid_cachep, new);
|