[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] [68/139] ifb: goto resched directly if error happens and dp->tq isn't empty
2.6.35-longterm review patch.  If anyone has any objections, please let me know.


From: Changli Gao <>

[ Upstream commit 75c1c82566f23dd539fb7ccbf57a1caa7ba82628 ]

If we break the loop when there are still skbs in tq and no skb in
rq, the skbs will be left in txq until new skbs are enqueued into rq.
In rare cases, no new skb is queued, then these skbs will stay in rq

After this patch, if tq isn't empty when we break the loop, we goto
resched directly.

Signed-off-by: Changli Gao <>
Signed-off-by: Jamal Hadi Salim <>
Signed-off-by: David S. Miller <>
Signed-off-by: Greg Kroah-Hartman <>
Signed-off-by: Andi Kleen <>

drivers/net/ifb.c | 2 ++
1 file changed, 2 insertions(+)

Index: linux-2.6.35.y/drivers/net/ifb.c
--- linux-2.6.35.y.orig/drivers/net/ifb.c
+++ linux-2.6.35.y/drivers/net/ifb.c
@@ -104,6 +104,8 @@ static void ri_tasklet(unsigned long dev
+ if (skb_queue_len(&dp->tq) != 0)
+ goto resched;

 \ /
  Last update: 2011-02-02 02:03    [W:0.582 / U:1.448 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site