lkml.org 
[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [105/139] n_gsm: gsm_data_alloc buffer allocation could fail and it is not being checked
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Ken Mills <ken.k.mills@intel.com>

    commit 093d804611b9a38fe59753b37c29f840518406a9 upstream.

    gsm_data_alloc buffer allocation could fail and it is not being checked.

    Add check for allocated buffer and return if the buffer allocation
    fails.

    Signed-off-by: Ken Mills <ken.k.mills@intel.com>
    Signed-off-by: Alan Cox <alan@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    drivers/char/n_gsm.c | 2 ++
    1 file changed, 2 insertions(+)

    Index: linux-2.6.35.y/drivers/char/n_gsm.c
    ===================================================================
    --- linux-2.6.35.y.orig/drivers/char/n_gsm.c
    +++ linux-2.6.35.y/drivers/char/n_gsm.c
    @@ -969,6 +969,8 @@ static void gsm_control_reply(struct gsm
    {
    struct gsm_msg *msg;
    msg = gsm_data_alloc(gsm, 0, dlen + 2, gsm->ftype);
    + if (msg == NULL)
    + return;
    msg->data[0] = (cmd & 0xFE) << 1 | EA; /* Clear C/R */
    msg->data[1] = (dlen << 1) | EA;
    memcpy(msg->data + 2, data, dlen);

    \
     
     \ /
      Last update: 2011-02-02 01:55    [W:0.032 / U:0.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site