Messages in this thread | | | Date | Tue, 1 Feb 2011 19:47:36 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH 1/2] hrtimers: extend hrtimer base code to handle more then 2 clockids |
| |
On Tue, 1 Feb 2011, John Stultz wrote: > On Tue, 2011-02-01 at 15:10 +0100, Thomas Gleixner wrote: > > On Mon, 31 Jan 2011, John Stultz wrote: > > > +static inline int hrtimer_clockid_to_base(clockid_t clock_id) > > > +{ > > > + int ret = hrtimer_clock_to_base_table[clock_id]; > > > + > > > + if(ret == -1) { > > > + WARN_ON(1); > > > + /* We just hit an invalid clock base, > > > + * but returning -1 isn't safe, so > > > + * return the _REALTIME base > > > + */ > > > > How can this happen ? > > It can't right now. I'm just worried someone will try to put a clockid > that doesn't have an hrtimer base into that function sometime in the > future. We can wrap it in a debug config maybe?
Hmm. That would have exploded the current code as well. So I won't worry too much about.
Thanks,
tglx
| |