Messages in this thread | | | Date | Fri, 9 Dec 2011 09:16:36 +0100 | From | Michael Hennerich <> | Subject | Re: [PATCH 2/2] Input: keyboard: Staticise non-exported symbols |
| |
On 12/09/2011 02:39 AM, Axel Lin wrote: > These symbols are not used outside it's driver so no need to > make the symbol global. > > Signed-off-by: Axel Lin<axel.lin@gmail.com> Acked-by: Michael Hennerich <michael.hennerich@analog.com> > --- > drivers/input/keyboard/bf54x-keys.c | 2 +- > drivers/input/keyboard/nomadik-ske-keypad.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c > index 683e314..8eb9116 100644 > --- a/drivers/input/keyboard/bf54x-keys.c > +++ b/drivers/input/keyboard/bf54x-keys.c > @@ -384,7 +384,7 @@ static int bfin_kpad_resume(struct platform_device *pdev) > # define bfin_kpad_resume NULL > #endif > > -struct platform_driver bfin_kpad_device_driver = { > +static struct platform_driver bfin_kpad_device_driver = { > .driver = { > .name = DRV_NAME, > .owner = THIS_MODULE, > diff --git a/drivers/input/keyboard/nomadik-ske-keypad.c b/drivers/input/keyboard/nomadik-ske-keypad.c > index 6c4828f..5a71e55 100644 > --- a/drivers/input/keyboard/nomadik-ske-keypad.c > +++ b/drivers/input/keyboard/nomadik-ske-keypad.c > @@ -379,7 +379,7 @@ static const struct dev_pm_ops ske_keypad_dev_pm_ops = { > }; > #endif > > -struct platform_driver ske_keypad_driver = { > +static struct platform_driver ske_keypad_driver = { > .driver = { > .name = "nmk-ske-keypad", > .owner = THIS_MODULE,
-- Greetings, Michael
-- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif
| |