Messages in this thread | | | Date | Sat, 10 Dec 2011 01:04:59 +0100 | Subject | Re: [PATCH] [RFC] pinctrl: add a driver for Energy Micro's efm32 SoCs | From | Linus Walleij <> |
| |
2011/12/9 Stephen Warren <swarren@nvidia.com>:
> Uwe Kleine-König wrote at Thursday, December 08, 2011 3:41 PM: >> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > >> +config PINMUX_EFM32 >> + bool "EFM32 pinmux driver" >> + depends on ARCH_EFM32 >> + default y >> + select PINMUX > > LinusW, > > Since this is the pinctrl not pinmux subsystem now, does it make sense > to name the driver Kconfig options PINCTRL_FOO and the files pinctrl- > foo.c? I see that the coh901 driver already does that, and I followed > that convention in my Tegra pinctrl patches.
Hm, the U300 pinmux is named pinmux-u300.c because it can only do pinmux. It cannot do anything else. But if it's confusing we can surely name everything pinctrl-*.
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |